Don't leave eval via next #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the build didn't fail ... travis failed. |
|
Why return 1 instead of just return? |
|
Usually "return 1" is used to indicate that something was successful. In this case it is used to indicate that the option was successfully processed. We could use a bare "return" instead, but that could possible lead to confusion in the future. I've seen plenty of examples where a little more verbosity would have prevented serious bugs, but I'd be fine with a bare return, too. Please advise. |
|
Ok, so bare return it is. I'll update the PR ASAP. |
Eval is not a loop and as such should not be left using loop control statements. This commit replaces those next statements with return statements. The control flow should be exactly the same since the enclosing loop will move on to the next iteration after a successfull return from the eval.
|
Using bare returns as per request and rebased to latest HEAD. |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eval is not a loop and as such should not be left
using loop control statements.
This commit replaces those next statements with return
statements. The control flow should be exactly the same
since the enclosing loop will move on to the next iteration
after a successfull return from the eval.